Beep/flash the ACR122 when a tag is detected #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uzzer when a tag is detected. Implement this method for the ACR122 device, and enable the behavior by default in the ContactlessFrontend.connect call.
nehpetsde
requested changes
Nov 9, 2016
|
Done. Let me know if I can help with the Python 3 changes at all. |
|
It's also worth mentioning that the ContactlessFrontend instance does not close gracefully for these ACR122 devices on the master branch. stable/0.11 works fine. |
|
Thanks, I could reproduce the closing issue and found the cause. Yet to think up the best solution but it'll come. |
|
The closing issue is now solved. |
|
Verified that my ACR122 closes successfully with the latest version of master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a couple methods to the abstract Device class that are intended to turn on/off an LED and buzzer if available. The default implementation does nothing. These methods are called by the _rdwr_connect method of the ContactlessFrontend, and can be disabled by setting the rdwr option 'beep-on-connect' to False.
The only device I have available is the ACR122, so I've implemented the on/off functionality in that particular device class. If other devices support similar notifications, it can easily be implemented in the device's class with no further changes to ContactlessFrontend.
This is my first contribution to nfcpy, so please let me know if there are any stylistic or documentation changes that I need to make. Thank you.