Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018_01_ATL_PHI: All 3rd Down and 4th Down Statistics Are "0" #246

Closed
JoeMarino2021 opened this issue Jun 15, 2021 · 1 comment · Fixed by #245
Closed

2018_01_ATL_PHI: All 3rd Down and 4th Down Statistics Are "0" #246

JoeMarino2021 opened this issue Jun 15, 2021 · 1 comment · Fixed by #245

Comments

@JoeMarino2021
Copy link

Let's load 2018's data. Then, let's look at the first game of the year.

library(tidyverse)
dfYearpbp <- nflfastR::load_pbp(2018)
dfYearpbp %>% filter(game_id == "2018_01_ATL_PHI") %>% select(third_down_converted, third_down_failed, fourth_down_converted, fourth_down_failed, down, desc) %>% View("ATL vs PHI 3rd and 4th Down Variables")

If you are using RStudio, you'll be looking at a data frame of selected variables from the first game of the year. All of the 3rd and 4th down variables are zero. Some of these should be 1.

Do you know what's going on here?

@guga31bb
Copy link
Member

Probably just this one game that's messed up. We fixed some columns (#32) but looks like there's more

guga31bb added a commit that referenced this issue Jun 15, 2021
@guga31bb guga31bb linked a pull request Jun 15, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants