Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] update_db() runs into error when using BigQuery importing season 2001 #389

Closed
2 tasks done
rstats-tips opened this issue Oct 15, 2022 · 1 comment
Closed
2 tasks done

Comments

@rstats-tips
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Have you installed the latest development version of the package(s) in question?

  • I have installed the latest development version of the package.

What version of the package do you have?

4.4.0.9012

Describe the bug

After implementing rstats-tips@953f7dc and running update_db() I get an error when season 2001 is imported.

The table created by update_db() on BigQuery has column weather of type BYTE. (I don't know why...)

Season 2001 is the first with weather data.

Reprex

library(tidyverse)
library(DBI)
library(nflfastR)


con <- dbConnect(
  bigrquery::bigquery(),
  project = "bigquery-sandbox-364615",
  # project = "bigquery-sandbox",
  dataset = "nfl_pbp",
  billing = "bigquery-sandbox-364615"
  # billing = "bigquery-sandbox"
)

dbListTables(con)

# copy_to(con, mtcars, "mtcars",
#         temporary = FALSE)

# load("~/tmp/season_2001.Rda")

# DBI::dbWriteTable(con, "nflfastR_pbp", pbp, append = TRUE)
# 
# DBI::dbWriteTable(con, "tmp", pbp %>% head(10), append = FALSE)

update_db(
  # dbname = "nfl_pbp",
  tblname = "nflfastR_pbp",
  db_connection = con,
  # force_rebuild = TRUE
  # force_rebuild = c(1999)
)

Expected Behavior

I expect the function to load all seasons into BigQuery.

nflverse_sitrep

── System Info ──────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.2.1 (2022-06-23)   • Running under: macOS Monterey 12.6
── nflverse Packages ────────────────────────────────────────────────────────────────────────────────────────────────────────
• nflreadr (1.3.1.02)    • nflseedR (1.1.0)       • nflplotR (1.1.0.9001)  
• nflfastR (4.4.0.9012)  • nfl4th   (1.0.2.9002)  • nflverse (1.0.2)       
── nflverse Options ─────────────────────────────────────────────────────────────────────────────────────────────────────────
No options set for nflreadr, nflfastR, nflseedR, nfl4th, nflplotR, and nflverse
── nflverse Dependencies ────────────────────────────────────────────────────────────────────────────────────────────────────
• askpass     (1.1)     • gtable      (0.3.1)     • progressr    (0.11.0)   
• bit         (4.0.4)   • hms         (1.1.2)     • proto        (1.0.0)    
• bit64       (4.0.5)   • httr        (1.4.4)     • purrr        (0.3.5)    
• cachem      (1.0.6)   • isoband     (0.2.6)     • R6           (2.5.1)    
• cli         (3.4.1)   • janitor     (2.1.0)     • rappdirs     (0.3.3)    
• clipr       (0.8.0)   • jsonlite    (1.8.2)     • RColorBrewer (1.1-3)    
• codetools   (0.2-18)  • labeling    (0.4.2)     • Rcpp         (1.0.9)    
• colorspace  (2.0-3)   • lattice     (0.20-45)   • readr        (2.1.3)    
• cpp11       (0.4.2)   • lifecycle   (1.0.3)     • rlang        (1.0.6)    
• crayon      (1.5.2)   • listenv     (0.8.0)     • rstudioapi   (0.14)     
• curl        (4.3.3)   • lubridate   (1.8.0)     • scales       (1.2.1)    
• data.table  (1.14.2)  • magick      (2.7.3)     • snakecase    (0.11.0)   
• digest      (0.6.29)  • magrittr    (2.0.3)     • stringi      (1.7.8)    
• dplyr       (1.0.10)  • MASS        (7.3-58.1)  • stringr      (1.4.1)    
• ellipsis    (0.3.2)   • Matrix      (1.5-1)     • sys          (3.4)      
• fansi       (1.0.3)   • memoise     (2.0.1)     • tibble       (3.1.8)    
• farver      (2.1.1)   • mgcv        (1.8-40)    • tidyr        (1.2.1)    
• fastmap     (1.1.0)   • mime        (0.12)      • tidyselect   (1.1.2)    
• fastrmodels (1.0.2)   • munsell     (0.5.0)     • tzdb         (0.3.0)    
• furrr       (0.3.1)   • nlme        (3.1-159)   • utf8         (1.2.2)    
• future      (1.28.0)  • openssl     (2.0.3)     • vctrs        (0.4.2)    
• generics    (0.1.3)   • parallelly  (1.32.1)    • viridisLite  (0.4.1)    
• ggplot2     (3.3.6)   • pillar      (1.8.1)     • vroom        (1.6.0)    
• globals     (0.16.1)  • pkgconfig   (2.0.3)     • withr        (2.5.0)    
• glue        (1.6.2)   • prettyunits (1.1.1)     • xgboost      (1.6.0.1)  
• gsubfn      (0.7)     • progress    (1.2.2)       
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Screenshots

No response

Additional context

No response

rstats-tips added a commit to rstats-tips/nflfastR that referenced this issue Oct 15, 2022
rstats-tips added a commit to rstats-tips/nflfastR that referenced this issue Oct 16, 2022
Start with the latest season. This season has column "weather" filled. So BigQuery will choose the right column type STRING.
@tanho63
Copy link
Member

tanho63 commented Nov 5, 2022

I think this is similarly a DBI spec implementation problem within bigqueryr. Closing for now.

@tanho63 tanho63 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants