Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): remove unused dependencies, move devDependencies where the… #145

Merged
merged 1 commit into from
Mar 17, 2022
Merged

fix(deps): remove unused dependencies, move devDependencies where the… #145

merged 1 commit into from
Mar 17, 2022

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Mar 17, 2022 •
edited
Loading

…y belong to

Fixes #

Proposed changes

Code quality

  • I made some tests for my changes
  • I added my name in the
    contributors
    field of the package.json file

License

To get your contribution merged, you must check the following.

  • I read the project license in the LICENSE file
  • I agree with publishing under this project license

Join

  • I wish to join the core team
  • I agree that with great powers comes responsibilities
  • I'm a nice person

My NPM username:

@coveralls
Copy link

coveralls commented Mar 17, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 56.995% when pulling ecc3d87 on XhmikosR:deps into ecc4902 on nfroidure:master.

@XhmikosR XhmikosR marked this pull request as ready for review March 17, 2022 07:56
@XhmikosR XhmikosR mentioned this pull request Mar 17, 2022
Closed
7 tasks
nfroidure
nfroidure approved these changes Mar 17, 2022
View reviewed changes
Copy link
Owner

@nfroidure nfroidure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nfroidure nfroidure merged commit 26d0914 into nfroidure:master Mar 17, 2022
@XhmikosR XhmikosR deleted the deps branch March 17, 2022 14:20
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Mar 18, 2022 •
edited
Loading

@nfroidure @pioug could you check the other two PRs too and cut a new patch version? The savings should be pretty significant for a second time in a row :)

@XhmikosR XhmikosR mentioned this pull request Apr 21, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfroidure nfroidure nfroidure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XhmikosR @coveralls @nfroidure