Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abc:exception): add typeDict of global config #1551

Merged
merged 1 commit into from Nov 11, 2022
Merged

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Nov 11, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Nov 11, 2022

Preview is ready!

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #1551 (bae8195) into master (4ed1aa4) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1551      +/-   ##
==========================================
- Coverage   95.61%   95.58%   -0.03%     
==========================================
  Files         272      272              
  Lines        8454     8455       +1     
  Branches     1658     1658              
==========================================
- Hits         8083     8082       -1     
- Misses        310      311       +1     
- Partials       61       62       +1     
Impacted Files Coverage Δ
packages/util/config/config.types.ts 100.00% <ø> (ø)
packages/abc/exception/exception.component.ts 100.00% <100.00%> (ø)
packages/theme/src/services/title/title.service.ts 97.14% <0.00%> (-2.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cipchk cipchk merged commit a408cbb into master Nov 11, 2022
@cipchk cipchk deleted the issues-2317 branch November 11, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants