New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template has been deprecated, need to change over to ng-template #1337

Closed
wesleycho opened this Issue Feb 25, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@wesleycho
Member

wesleycho commented Feb 25, 2017

I took a peek at Angular 4.0.0-rc.1, and noticed messages that the template tag has been deprecated in favor of ng-template - this is a breaking change that will need to be scheduled sometime after Angular 4 goes live.

@somombo

This comment has been minimized.

somombo commented Feb 26, 2017

I'd like to talk about some changes we can make in the meantime.

Kindly refer to Issue #1344

and PR #1343

@somombo

This comment has been minimized.

somombo commented Mar 1, 2017

@pkozlowski-opensource in #1344 (comment):
you seem to be implying that there is a problem with using <template> / <ng-template> and I wholeheartedly disagree - usage of <template> / <ng-template> was / is conscious design decision that was discussed at length with Misko and material teams.

I just wanted to point out that you mention the material team, as an example, I presume, of an authority that exemplifies the best practices for building good quality angular libraries.. Yet there is not one single line of non-spec code in the angular material 2 lib where they use <template> ... let alone using it to the extent that it's been used in this project.

If even they were able to get by in that project without using <template> even once, why is it that this project could not? Are they solving the performance issues you mentioned in some sort of novel way that this project has not explored or thought about yet?

@pkozlowski-opensource

This comment has been minimized.

Member

pkozlowski-opensource commented Mar 24, 2017

Another update: number of logs for this case was trimmed down significantly on the Angular side via angular/angular#15364 and once again, this is only debug-time warning.

We can't rename all the <template> occurrences to <ng-template> before we decide to require Angular 4.0.0 as a minimal version. IMO it is too soon to drop 2.3.x support so here is the plan: let's wait a couple of weeks till Bootstrap 4.beta is released and then we can cut a beta that bumps up Bootstrap and Angular dependencies.

For now there is no point of loosing sleep over this warning - we are aware of why it is logged and got a plan of update to 4.0.x

@pkozlowski-opensource

This comment has been minimized.

Member

pkozlowski-opensource commented Apr 5, 2017

Plan for the complete switch to Angular 4 here: #1439

@pkozlowski-opensource pkozlowski-opensource added this to the Only Angular 4 milestone Apr 5, 2017

@pkozlowski-opensource pkozlowski-opensource referenced this issue Apr 22, 2017

Closed

Move to Angular 4 #1439

7 of 7 tasks complete

pkozlowski-opensource added a commit to pkozlowski-opensource/core that referenced this issue Apr 23, 2017

feat: bump up Angular dependency to 4.0.3
Closes ng-bootstrap#1337
Closes ng-bootstrap#1415
Closes ng-bootstrap#1433
Closes ng-bootstrap#1439

BREAKING CHANGE:

ng-bootstrap requires a minimal version of Angular 4.0.3

pkozlowski-opensource added a commit to pkozlowski-opensource/core that referenced this issue Apr 23, 2017

feat: bump up Angular dependency to 4.0.3
Closes ng-bootstrap#1337
Closes ng-bootstrap#1415
Closes ng-bootstrap#1433
Closes ng-bootstrap#1439

BREAKING CHANGE:

ng-bootstrap requires a minimal version of Angular 4.0.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment