Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor + update to v4 #7

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@benouat
Copy link
Member

commented Dec 3, 2018

Missing part would be adding:

@benouat

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2018

cc @pkozlowski-opensource @maxokorokov if you wan't to have a look... feel free to ask for more details if needed.

Next step would be to publishv4.0.0 as soon as merged.

@maxokorokov
Copy link
Member

left a comment

LGTM overall!

I tired:

  • following the readme to run tests → OK
  • running schematics on a new project with 7.1 → OK

I didn't go deep into implementation details, but now we can use tools from @schematics/angular/utility, which is nice!

Comments:

  • CLI has the following options when creating a new project:

screen shot 2018-12-13 at 11 39 27

I guess now we support only CSS and SCSS, should we add others ?
It doesn't crash with SASS, for instance, just doesn't add any styles to a CLI project.

"workspace",
{
name: "workspace",
version: "6.0.0",

This comment has been minimized.

Copy link
@maxokorokov

maxokorokov Dec 13, 2018

Member

What is this version, shouldn't it be '7.0.0' ?

"dependencies": {
"@angular-devkit/core": "^7.0.6",
"@angular-devkit/schematics": "^7.0.6",
"@schematics/angular": "^7.0.6",

This comment has been minimized.

Copy link
@maxokorokov

maxokorokov Dec 13, 2018

Member

I wonder if there any relation between Angular version, CLI version and our dependencies in dist/package.json:

"dependencies": {
    "@angular-devkit/core": "^7.0.6",
    "@angular-devkit/schematics": "^7.0.6",
    "@schematics/angular": "^7.0.6",
    "typescript": "~3.1.4"
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.