Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Integration with `rollup-plugin-alias` #1387

Closed
JounQin opened this issue Aug 26, 2019 · 1 comment
Closed

[Feature Request] Integration with `rollup-plugin-alias` #1387

JounQin opened this issue Aug 26, 2019 · 1 comment

Comments

@JounQin
Copy link

@JounQin JounQin commented Aug 26, 2019

Type of Issue

  • Bug Report
  • Feature Request

Description

A bug: please describe the error that you encountered

A feature: please describe your use case and motivation

Support rollup-plugin-alias for aliasing from loash-es -> lodash.

How To Reproduce

A bug: please include instructions how to reproduce. Issues without reproduction are likely to receive no feedback.

Can you reproduce the error in the integration tests in ng-packagr?
If possible, take a look at the integration/samples and try to break one of these builds!

Is the error you faced in an application importing the library
Try to break the Angular CLI app in integration/consumers/ng-cli!

Expected Behaviour

A bug: please describe what behaviour or result you expected

A feature: do you have a first draft or an idea how to implement?

{
  "alias": {
    "lodash": "lodash-es"
  }
}

Something like parcel resolution which reads it from package.json.

Version Information

$ node_modules/.bin/ng-packagr --version
ng-packagr: 5.5.0
@angular/*: 8.2.3
typescript: 3.5.3
rxjs: 6.5.2
node: v12.8.1
yarn: 1.17.3

Please include all version numbers that might be relevant, e.g. third-party libraries

@alan-agius4

This comment has been minimized.

Copy link
Contributor

@alan-agius4 alan-agius4 commented Sep 4, 2019

Hi, thanks for the interest, however rollup is only used to generate FESM and UMD bundles and it will not process ESM bundles.

Hence, we cannot add any transformers/plugins in the pipeline unless they are a must to either generate FESMs or UMD bundles.

@alan-agius4 alan-agius4 closed this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.