Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setting focus to input element only if its not readonly, fixes 2133 #2134

Merged
merged 4 commits into from Mar 24, 2023

Conversation

giriprashaad
Copy link
Contributor

This prevents safari 16.0 from jumping to the top as it seems Safari 16.0 doesn't like setting focus on a readonly element

@giriprashaad
Copy link
Contributor Author

#2133 issue fix

@pavankjadda
Copy link
Collaborator

@giriprashaad See my comment

@pavankjadda pavankjadda self-requested a review November 22, 2022 06:04
@pavankjadda pavankjadda self-assigned this Nov 22, 2022
@pavankjadda pavankjadda added the needs reproduction needs reproducible example label Nov 22, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🎆

@github-actions github-actions bot added the stale label Jan 22, 2023
@github-actions github-actions bot closed this Jan 29, 2023
@jamieb25
Copy link

jamieb25 commented Feb 6, 2023

Also having this issue!

@pavankjadda pavankjadda reopened this Mar 24, 2023
@pavankjadda pavankjadda changed the title setting focus to input element only if its not readonly fix: setting focus to input element only if its not readonly, fixes 2133 Mar 24, 2023
@pavankjadda pavankjadda merged commit 97bb1ff into ng-select:master Mar 24, 2023
6 checks passed
pavankjadda added a commit that referenced this pull request Mar 24, 2023
… prevents safari 16 to jump to the top (#2134)"

This reverts commit 97bb1ff.
@github-actions
Copy link

🎉 This PR is included in version 10.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reproduction needs reproducible example released stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants