-
Notifications
You must be signed in to change notification settings - Fork 39
feat(NETWORK_INFORMATION): add new token #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NETWORK_INFORMATION): add new token #11
Conversation
|
I wonder if it should be named NETWORK_INFORMATION or CONNECTION. @MarsiBarsi what do you think? |
587394b to
eed0970
Compare
|
@waterplea NETWORK_INFORMATION is more informative for me instead of CONNECTION 😁 Please check the pr again, I force pushed the changes |
|
both options are okay for me 👍 |
eed0970 to
a1b8148
Compare
|
@waterplea I have reverted the change of returns |
|
@thekiba instead you can add a second test where you would mock |
a1b8148 to
c44899c
Compare
|
It's a success now 🙌 |
|
All looks well now. I wonder if there's a way not to force everybody to install those types if they do not use this token 🤔 |
|
@MarsiBarsi what if we bundle it? It's just types, shouldn't really matter. What do you think? |
|
@waterplea I think it is a good idea. Let's make the type with "TODO to remove" after adding TS support |
|
Took the liberty to do those changes, related to types bundling. Looks like it works fine now, I tried a pre-release version on my pet project. Thank you, @thekiba ! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information