New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf regression fixed in master #2

Closed
petehunt opened this Issue Jan 15, 2014 · 5 comments

Comments

Projects
None yet
4 participants
@petehunt

petehunt commented Jan 15, 2014

Hey @davidchang, great writeup!

Your second render being slow was a regression on our end. We've fixed the bug in master and now all of your renders should be fast!

@slorber

This comment has been minimized.

Show comment
Hide comment
@slorber

slorber Jan 16, 2014

cool ! @davidchang let us know if this solves the perf issue on your side

slorber commented Jan 16, 2014

cool ! @davidchang let us know if this solves the perf issue on your side

@hasdavidc

This comment has been minimized.

Show comment
Hide comment
@hasdavidc

hasdavidc Jan 17, 2014

Collaborator

Thanks @petehunt - I'll check it out soon and update status here/on the blog post

Collaborator

hasdavidc commented Jan 17, 2014

Thanks @petehunt - I'll check it out soon and update status here/on the blog post

@elbuo8

This comment has been minimized.

Show comment
Hide comment
@elbuo8

elbuo8 Feb 12, 2014

Bump? :(

elbuo8 commented Feb 12, 2014

Bump? :(

@hasdavidc

This comment has been minimized.

Show comment
Hide comment
@hasdavidc

hasdavidc Feb 17, 2014

Collaborator

Sorry all. Consider it bumped

Collaborator

hasdavidc commented Feb 17, 2014

Sorry all. Consider it bumped

@hasdavidc

This comment has been minimized.

Show comment
Hide comment
@hasdavidc

hasdavidc Feb 19, 2014

Collaborator

Without making any changes, here are the numbers for running the ngReact benchmark I had come up with:

version Total for 10 iterations Second Load Average lower end Average higher end
0.8 803ms 433ms 35ms 55ms
0.9.0-rc1 542ms 150ms 40ms 47ms

screen shot 2014-02-19 at 9 44 31 am

I'm still trying to figure how I can make the ngReactRepeat directive (the one that just transcludes) run faster; with version 0.8, 10 iterations was logging 13.4 seconds. After upgrading only to 0.9.0-rc1, 10 iterations logged 12.53 seconds.

Gonna go ahead and close - feel free to reopen if any issues/questions

Collaborator

hasdavidc commented Feb 19, 2014

Without making any changes, here are the numbers for running the ngReact benchmark I had come up with:

version Total for 10 iterations Second Load Average lower end Average higher end
0.8 803ms 433ms 35ms 55ms
0.9.0-rc1 542ms 150ms 40ms 47ms

screen shot 2014-02-19 at 9 44 31 am

I'm still trying to figure how I can make the ngReactRepeat directive (the one that just transcludes) run faster; with version 0.8, 10 iterations was logging 13.4 seconds. After upgrading only to 0.9.0-rc1, 10 iterations logged 12.53 seconds.

Gonna go ahead and close - feel free to reopen if any issues/questions

@hasdavidc hasdavidc closed this Feb 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment