From e2036761183b871e6806a20ab4eac6aa0858ddec Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Wed, 2 Nov 2022 12:21:21 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- analyze_results.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/analyze_results.py b/analyze_results.py index b0ad4ad..a051efa 100644 --- a/analyze_results.py +++ b/analyze_results.py @@ -27,7 +27,26 @@ tarinfo for tarinfo in tar.getmembers() if tarinfo.name.startswith('hls') ] - tar.extractall(members=subdir_and_files) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, members=subdir_and_files) else: continue