Skip to content

Conversation

@resmo
Copy link
Member

@resmo resmo commented Sep 11, 2020

Closes #30
/cc @rvalle

Todos:

@resmo resmo changed the title cs_ip_address: Implement assosiate with given IP address [WIP] cs_ip_address: Implement assosiate with given IP address Sep 11, 2020
@resmo resmo added this to the v1.1.0 milestone Sep 11, 2020
@rvalle
Copy link
Collaborator

rvalle commented Sep 11, 2020

man! that was quick.

@resmo
Copy link
Member Author

resmo commented Sep 11, 2020

Waiting for CI to pass, I don't expect this breaks anything for cloudstack <4.13.

@rvalle
Copy link
Collaborator

rvalle commented Sep 11, 2020

I was looking at adding the test. But I am missing the IP range. I don't see anything in cs_common. Where are the ip_ranges?

I remember I file to boostrap the emulator somewhere... just cant find it.

Something seems off here. I cannot trace the start of the simulator from any file in this repo. Is it managed by the ansible-test distribution? Yes, in test/lib folder which is not in this repo....

How is that going to work once the collection is independent form ansible? in 2.10+

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #31 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   84.40%   84.38%   -0.02%     
==========================================
  Files          53       53              
  Lines        5509     5509              
  Branches     1246     1246              
==========================================
- Hits         4650     4649       -1     
  Misses        432      432              
- Partials      427      428       +1     
Impacted Files Coverage Δ
plugins/modules/cs_region.py
plugins/modules/cs_storage_pool.py
plugins/modules/cs_instancegroup.py
plugins/modules/cs_host.py
plugins/modules/cs_zone_info.py
plugins/modules/cs_loadbalancer_rule.py
plugins/modules/cs_instance_info.py
plugins/modules/cs_project.py
plugins/modules/cs_instance_password_reset.py
plugins/modules/cs_configuration.py
... and 95 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c6348c...5091204. Read the comment docs.

@rvalle
Copy link
Collaborator

rvalle commented Sep 11, 2020

this seems to be it: https://github.com/ansible/cloudstack-test-container/blob/1.2.0/zones.cfg
Not sure why I am running 1.2.0 I guess my local ansible...
on the tests now...

@rvalle
Copy link
Collaborator

rvalle commented Sep 11, 2020

mmm can't push here... and PR from my fork created a new PR ins instead of modifying this.

the tests don't pass, I think due to 4.11 based simulator

@resmo
Copy link
Member Author

resmo commented Sep 11, 2020

mmm can't pull here...

its on quay.io, not on docker hub.
yes, we need an updated simulator to actually test this

@resmo resmo changed the title [WIP] cs_ip_address: Implement assosiate with given IP address cs_ip_address: Implement assosiate with given IP address Sep 12, 2020
@resmo
Copy link
Member Author

resmo commented Sep 12, 2020

Ci passed and I don't have any concerns it could break anything. Merging...

@resmo resmo force-pushed the feature/cs_ip_address_ip_reservation branch from 181303d to 5091204 Compare September 12, 2020 07:59
@resmo resmo merged commit 8326b8f into master Sep 12, 2020
@resmo resmo deleted the feature/cs_ip_address_ip_reservation branch September 12, 2020 16:33
@resmo
Copy link
Member Author

resmo commented Sep 12, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Picking a particular IP address for a Network

3 participants