-
-
Notifications
You must be signed in to change notification settings - Fork 33
cs_ip_address: Implement assosiate with given IP address #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
man! that was quick. |
|
Waiting for CI to pass, I don't expect this breaks anything for cloudstack <4.13. |
|
I was looking at adding the test. But I am missing the IP range. I don't see anything in cs_common. Where are the ip_ranges? I remember I file to boostrap the emulator somewhere... just cant find it. Something seems off here. I cannot trace the start of the simulator from any file in this repo. Is it managed by the ansible-test distribution? Yes, in test/lib folder which is not in this repo.... How is that going to work once the collection is independent form ansible? in 2.10+ |
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 84.40% 84.38% -0.02%
==========================================
Files 53 53
Lines 5509 5509
Branches 1246 1246
==========================================
- Hits 4650 4649 -1
Misses 432 432
- Partials 427 428 +1 Continue to review full report at Codecov.
|
|
this seems to be it: https://github.com/ansible/cloudstack-test-container/blob/1.2.0/zones.cfg |
|
mmm can't push here... and PR from my fork created a new PR ins instead of modifying this. the tests don't pass, I think due to 4.11 based simulator |
its on quay.io, not on docker hub. |
|
Ci passed and I don't have any concerns it could break anything. Merging... |
181303d to
5091204
Compare
|
Thanks! |
Closes #30
/cc @rvalle
Todos: