Skip to content

Conversation

@rvalle
Copy link
Collaborator

@rvalle rvalle commented Sep 11, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #33 into feature/cs_ip_address_ip_reservation will decrease coverage by 10.50%.
The diff coverage is n/a.

Impacted file tree graph

@@                            Coverage Diff                            @@
##           feature/cs_ip_address_ip_reservation      #33       +/-   ##
=========================================================================
- Coverage                                 84.40%   73.90%   -10.51%     
=========================================================================
  Files                                        53       36       -17     
  Lines                                      5509     4169     -1340     
  Branches                                   1246      984      -262     
=========================================================================
- Hits                                       4650     3081     -1569     
- Misses                                      432      710      +278     
+ Partials                                    427      378       -49     
Impacted Files Coverage Δ
plugins/modules/cs_physical_network.py 39.53% <0.00%> (-43.03%) ⬇️
plugins/modules/cs_domain.py 57.77% <0.00%> (-37.78%) ⬇️
plugins/modules/cs_account.py 46.21% <0.00%> (-36.37%) ⬇️
plugins/modules/cs_host.py 52.38% <0.00%> (-33.34%) ⬇️
plugins/modules/cs_instance.py 49.65% <0.00%> (-21.19%) ⬇️
plugins/modules/cs_network.py 64.39% <0.00%> (-16.67%) ⬇️
plugins/modules/cs_ip_address.py 75.71% <0.00%> (-14.29%) ⬇️
plugins/modules/cs_instance_info.py 70.14% <0.00%> (-8.96%) ⬇️
plugins/module_utils/cloudstack.py 65.76% <0.00%> (-6.76%) ⬇️
plugins/modules/cs_instancegroup.py
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 540df85...5d2f832. Read the comment docs.

Copy link
Member

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, on hold until we updated the simulator

@rvalle
Copy link
Collaborator Author

rvalle commented Sep 11, 2020

@resmo shall I test also for VPCs?

@rvalle
Copy link
Collaborator Author

rvalle commented Sep 11, 2020

building the simulator for 4.13.1.0 which is the last LTS, if test pass I will PR there...

@rvalle
Copy link
Collaborator Author

rvalle commented Sep 11, 2020

@resmo I assume you are aware but the simulator for the 4.13 LTS does not build due to Python 2 deprecation. Maybe I have a quick look, I guess pinning a version or a dependency might be enough, or perhaps migrating to Python 3 is not that hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants