Skip to content

Handle nginx instance with no config args #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2022
Merged

Handle nginx instance with no config args #105

merged 1 commit into from
Nov 16, 2022

Conversation

@dhurley
Copy link
Collaborator

@dhurley dhurley commented Nov 10, 2022 •
edited
Loading

Proposed changes

Updated getNginxInfoFromBuffer function to handle the scenario where nginx has no config arguments

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@dhurley dhurley self-assigned this Nov 10, 2022
@dhurley dhurley added the chore Pull requests for routine tasks label Nov 10, 2022
@dhurley dhurley added bug Something isn't working and removed chore Pull requests for routine tasks labels Nov 16, 2022
@dhurley dhurley merged commit 9d8026e into main Nov 16, 2022
@dhurley dhurley deleted the handle-nginx-oss-with-no-prefix branch November 16, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aphralG aphralG aphralG approved these changes

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

@craigell craigell Awaiting requested review from craigell

+1 more reviewer

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dhurley dhurley

Labels

bug Something isn't working dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhurley @Dean-Coakley @aphralG