Skip to content

fix: safe parsing for access request log and violation log #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2022
Merged

fix: safe parsing for access request log and violation log #109

merged 1 commit into from
Nov 11, 2022

Conversation

@sanathkumarbs
Copy link

@sanathkumarbs sanathkumarbs commented Nov 11, 2022 •
edited by oCHRISo
Loading

Proposed changes

Desccription:

Agent fatally crashes while parsing Access Logs that contain spaces in the requests. This causes the Agent to restart itself and all other plugins and extensions loaded.

Additionally, this also fixes the parsing issue with the security violation logs for the URI field

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@sanathkumarbs sanathkumarbs self-assigned this Nov 11, 2022
@github-actions github-actions bot added the bug Something isn't working label Nov 11, 2022
nickchen
nickchen approved these changes Nov 11, 2022
View reviewed changes
Copy link

@nickchen nickchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanathkumarbs sanathkumarbs changed the title fix: safe parsing for access request log fix: safe parsing for access request log and violation log Nov 11, 2022
@sanathkumarbs sanathkumarbs merged commit 6a78111 into main Nov 11, 2022
@oliveromahony oliveromahony deleted the fix-access-log-parsing branch November 16, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

@aphralG aphralG Awaiting requested review from aphralG

@craigell craigell Awaiting requested review from craigell

@dhurley dhurley Awaiting requested review from dhurley

3 more reviewers

@nickchen nickchen nickchen approved these changes

@wicklander-bryant wicklander-bryant wicklander-bryant approved these changes

@yluf5 yluf5 yluf5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sanathkumarbs sanathkumarbs

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sanathkumarbs @nickchen @wicklander-bryant @yluf5