From 2611b53ed0ab308c929ef82dbc7f2a4be58841ee Mon Sep 17 00:00:00 2001 From: sanathkumarbs Date: Tue, 15 Nov 2022 19:21:26 -0800 Subject: [PATCH] fix: split subviolations and tc by comma --- .../nginx-app-protect/monitoring/processor/nap.go | 4 ++-- .../processor/testdata/expanded_nap_waf.log.txt | 2 +- .../monitoring/processor/testdata/xml_header_data.log.txt | 2 +- .../processor/testdata/xml_parameter_data.log.txt | 2 +- .../testdata/xml_parameter_data_as_param_data.log.txt | 2 +- .../testdata/xml_parameter_data_empty_context.log.txt | 2 +- .../processor/testdata/xml_signature_data.log.txt | 2 +- .../processor/testdata/xml_violation_name.log.txt | 2 +- src/plugins/nap_monitoring.go | 2 +- .../testData/events-out/expanded_nap_waf.log.txt.out | 8 ++++---- .../testData/events-out/xml_header_data.log.txt.out | 8 ++++---- .../testData/events-out/xml_parameter_data.log.txt.out | 8 ++++---- .../xml_parameter_data_as_param_data.log.txt.out | 8 ++++---- .../xml_parameter_data_empty_context.log.txt.out | 8 ++++---- .../testData/events-out/xml_signature_data.log.txt.out | 8 ++++---- .../testData/events-out/xml_violation_name.log.txt.out | 8 ++++---- .../monitoring/testData/logs-in/expanded_nap_waf.log.txt | 2 +- .../monitoring/testData/logs-in/xml_header_data.log.txt | 2 +- .../testData/logs-in/xml_parameter_data.log.txt | 2 +- .../logs-in/xml_parameter_data_as_param_data.log.txt | 2 +- .../logs-in/xml_parameter_data_empty_context.log.txt | 2 +- .../testData/logs-in/xml_signature_data.log.txt | 2 +- .../testData/logs-in/xml_violation_name.log.txt | 2 +- 23 files changed, 45 insertions(+), 45 deletions(-) diff --git a/src/extensions/nginx-app-protect/monitoring/processor/nap.go b/src/extensions/nginx-app-protect/monitoring/processor/nap.go index 4ee606406..9a93efe49 100644 --- a/src/extensions/nginx-app-protect/monitoring/processor/nap.go +++ b/src/extensions/nginx-app-protect/monitoring/processor/nap.go @@ -464,7 +464,7 @@ func setValue(napConfig *NAPConfig, key, value string, logger *logrus.Entry) err case sigSetNames: napConfig.SigSetNames = replaceEncodedList(value, listSeperator) case threatCampaignNames: - napConfig.ThreatCampaignNames = value + napConfig.ThreatCampaignNames = replaceEncodedList(value, listSeperator) case violationDetails: napConfig.ViolationDetailsXML = func(data string) *BADMSG { var xmlData BADMSG @@ -513,7 +513,7 @@ func setValue(napConfig *NAPConfig, key, value string, logger *logrus.Entry) err case sigCVEs: napConfig.SignatureCVEs = replaceEncodedList(value, listSeperator) case subViolations: - napConfig.SubViolations = value + napConfig.SubViolations = replaceEncodedList(value, listSeperator) case supportID: napConfig.SupportID = value case violations: diff --git a/src/extensions/nginx-app-protect/monitoring/processor/testdata/expanded_nap_waf.log.txt b/src/extensions/nginx-app-protect/monitoring/processor/testdata/expanded_nap_waf.log.txt index 3580c2d44..ed7cc6e70 100644 --- a/src/extensions/nginx-app-protect/monitoring/processor/testdata/expanded_nap_waf.log.txt +++ b/src/extensions/nginx-app-protect/monitoring/processor/testdata/expanded_nap_waf.log.txt @@ -1 +1 @@ -N/A,80,127.0.0.1,,GET,app_protect_default_policy,HTTP,blocked,0,Critical,::,{Cross Site Scripting Signatures;High Accuracy Signatures}::{Cross Site Scripting Signatures;High Accuracy Signatures},61478,HTTP protocol compliance failed:Host header contains IP address,4355056874564592513,N/A,5,1-localhost:1-/,N/A,REJECTED,SECURITY_WAF_VIOLATION,HTTP protocol compliance failed::Illegal meta character in value::Attack signature detected::Violation Rating Threat detected::Bot Client Detected,410000000200c00-3a03030c30000072-8000000000000000-0477f0ffcbbd0fea-befbf35cb000007e-8000000000000000-00-20-0-00-0-0-042VIOL_ATTACK_SIGNATUREparameterglobalYQ==alpha-numericPHNjcmlwdD4=query*002000014753YT08c2NyaXB0Pg==372000000983YT08c2NyaXB0Pg==2714VIOL_HTTP_PROTOCOL20482048SG9zdCBoZWFkZXIgd2l0aCBJUCB2YWx1ZTogMTAuMTQ2LjE3OS4xMTk=24VIOL_PARAMETER_VALUE_METACHARglobalYQ==alpha-numericPHNjcmlwdD4=query*046062,curl,HTTP Library,N/A,N/A,Untrusted Bot,N/A,N/A,/,GET /?a=