Skip to content

added new proto changes for preventing a config apply and reporting NAP Health #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2022
Merged

added new proto changes for preventing a config apply and reporting NAP Health #116

merged 2 commits into from
Nov 23, 2022

Conversation

@oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Nov 22, 2022

Proposed changes

Added new proto changes for preventing a config apply and reporting NAP Health

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@oliveromahony oliveromahony merged commit 35ef4c0 into main Nov 23, 2022
@oliveromahony oliveromahony deleted the protochanges branch November 23, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aphralG aphralG aphralG approved these changes

@dhurley dhurley Awaiting requested review from dhurley

@craigell craigell Awaiting requested review from craigell

+1 more reviewer

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oliveromahony @Dean-Coakley @aphralG