Skip to content

fix: change agent-config back to previous values #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: change agent-config back to previous values #133

wants to merge 1 commit into from

Conversation

@nickchen
Copy link

@nickchen nickchen commented Dec 5, 2022 •
edited
Loading

Proposed changes

  • unset the conf changes from fixed metrics #127, which is currently breaking automation, change looks accidental as there were no mention of it in the PR description

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • [0] If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@github-actions github-actions bot added the bug Something isn't working label Dec 5, 2022
wicklander-bryant
wicklander-bryant approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@wicklander-bryant wicklander-bryant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliveromahony oliveromahony deleted the reset-agent-conf branch February 21, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

@dhurley dhurley Awaiting requested review from dhurley

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

@yluf5 yluf5 Awaiting requested review from yluf5

3 more reviewers

@wdz111 wdz111 wdz111 approved these changes

@wicklander-bryant wicklander-bryant wicklander-bryant approved these changes

@tstraley tstraley tstraley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nickchen @wdz111 @wicklander-bryant @tstraley @oliveromahony @nginx-nickc