Skip to content

Add install/uninstall integration test #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Feb 8, 2023
Merged

Add install/uninstall integration test #147

merged 29 commits into from
Feb 8, 2023

Conversation

@Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Dec 12, 2022 •
edited
Loading

Proposed changes

  • Convert install/uninstall to be an integration test
  • Run install/uninstall test on push CI via make integration-test target
  • Test no longer depends on nginx running
  • Install/uninstall test now uses local package
  • Test run against docker container. ubuntu is the only supported image at the moment.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@Dean-Coakley
Add install test to CI
ef3438a 
Only assert for user detection if nginx is installed

Change Makefile to find signed packages
@Dean-Coakley
Fix apk package build
ff71fab
@Dean-Coakley Dean-Coakley self-assigned this Dec 12, 2022
@netlify
Copy link

netlify bot commented Dec 12, 2022 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 3e89b35
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/63dd7ced18d41c0008ee7078

@Dean-Coakley Dean-Coakley added the enhancement New feature or request label Dec 12, 2022
oliveromahony
oliveromahony reviewed Dec 16, 2022
View reviewed changes
craigell
craigell reviewed Jan 9, 2023
View reviewed changes
@dhurley dhurley added chore Pull requests for routine tasks and removed enhancement New feature or request labels Jan 10, 2023
dhurley
dhurley reviewed Jan 25, 2023
View reviewed changes
oliveromahony
oliveromahony reviewed Jan 31, 2023
View reviewed changes
craigell
craigell reviewed Jan 31, 2023
View reviewed changes
oliveromahony
oliveromahony reviewed Jan 31, 2023
View reviewed changes
dhurley
dhurley reviewed Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@dhurley dhurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just have a few minor comments

oliveromahony
oliveromahony reviewed Feb 3, 2023
View reviewed changes
oliveromahony
oliveromahony reviewed Feb 3, 2023
View reviewed changes
@dhurley dhurley removed documentation Improvements or additions to documentation dependencies labels Feb 8, 2023
@oliveromahony oliveromahony merged commit c057452 into main Feb 8, 2023
@oliveromahony oliveromahony deleted the run-install-test branch February 8, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhurley dhurley dhurley approved these changes

@aphralG aphralG aphralG approved these changes

@craigell craigell Awaiting requested review from craigell

+1 more reviewer

@oliveromahony oliveromahony oliveromahony approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Dean-Coakley Dean-Coakley

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Dean-Coakley @oliveromahony @dhurley @craigell @aphralG