Skip to content

WIP: Remove the default gRPC configuration for the nginx-agent #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2022
Merged

WIP: Remove the default gRPC configuration for the nginx-agent #149

merged 3 commits into from
Dec 16, 2022

Conversation

@oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Dec 13, 2022

Proposed changes

Remove the default gRPC configuration. This uses REST by default

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@oliveromahony oliveromahony self-assigned this Dec 13, 2022
@netlify
Copy link

netlify bot commented Dec 13, 2022 •
edited
Loading

✅ Deploy Preview for agent-public-docs ready!

Name Link
🔨 Latest commit 0433e8f
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/63986b6fdb5f7900099c84ce
😎 Deploy Preview https://deploy-preview-149--agent-public-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 13, 2022
mtbChef
mtbChef suggested changes Dec 14, 2022
View reviewed changes
Copy link

@mtbChef mtbChef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo in the readme

@oliveromahony oliveromahony changed the title Remove the default gRPC configuration for the nginx-agent Draft: Remove the default gRPC configuration for the nginx-agent Dec 16, 2022
@oliveromahony oliveromahony changed the title Draft: Remove the default gRPC configuration for the nginx-agent WIP: Remove the default gRPC configuration for the nginx-agent Dec 16, 2022
@mtbChef mtbChef merged commit ea3a1b4 into main Dec 16, 2022
@mtbChef mtbChef deleted the default-grpc-removal branch December 16, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JTorreG JTorreG JTorreG approved these changes

@dhurley dhurley dhurley approved these changes

@craigell craigell Awaiting requested review from craigell

@aphralG aphralG Awaiting requested review from aphralG

+2 more reviewers

@mtbChef mtbChef mtbChef approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@oliveromahony oliveromahony

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oliveromahony @dhurley @mtbChef @Dean-Coakley @JTorreG