Skip to content

Conversation

@CVanF5
Copy link
Collaborator

@CVanF5 CVanF5 commented Dec 16, 2022

Proposed changes

Updates the FreeBSD rc.d script to use the standard FreeBSD rc.subr template. This reduces the complexity of the file and fixes some errors that occurs when running service nginx-agent restart

freebsd@testenv-3dd5fc2a-data-1:~ $ sudo service nginx-agent restart
nginx_agent already running?  (pid=3902).
freebsd@testenv-3dd5fc2a-data-1:~ $ sudo service nginx-agent restart
cat: /var/run/nginx_agent.pid: No such file or directory
kill: illegal process id: 
freebsd@testenv-3dd5fc2a-data-1:~ $ echo $?
1

Updated script

freebsd@testenv-3dd5fc2a-data-1:~ $ sudo service nginx-agent restart
Stopping nginx_agent.
Waiting for PIDS: 4081, 4081.
Starting nginx_agent.
freebsd@testenv-3dd5fc2a-data-1:~ $ echo $?
0

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@netlify
Copy link

netlify bot commented Dec 16, 2022

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 4f40bd9
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/639c9f4ed51eb300082715b6

@oliveromahony oliveromahony requested a review from craigell January 6, 2023 14:40
@CVanF5
Copy link
Collaborator Author

CVanF5 commented Jan 6, 2023

Thanks for the approval! I'm not authorized to merge, so I thought I'd just leave this note in case someone else feels like pushing the button.

@sanathkumarbs sanathkumarbs merged commit 89c6b79 into nginx:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants