Skip to content

GitHub release workflow improvements #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 17, 2023
Merged

GitHub release workflow improvements #168

merged 6 commits into from
Jan 17, 2023

Conversation

@dhurley
Copy link
Collaborator

@dhurley dhurley commented Jan 13, 2023 •
edited
Loading

Proposed changes

  • Removed CHANGELOG.md as we are already tracking the changes in the github release page https://github.com/nginx/agent/releases. (Updated docs to point to the release page instead of CHANGELOG.md)
  • Updated release workflow to determine the tag version from the release branch name.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@netlify
Copy link

netlify bot commented Jan 13, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 8638b88
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/63c57c731a77610009ca3940

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 13, 2023
@dhurley dhurley self-assigned this Jan 13, 2023
@dhurley dhurley added the chore Pull requests for routine tasks label Jan 13, 2023
Dean-Coakley
Dean-Coakley approved these changes Jan 16, 2023
View reviewed changes
dhurley and others added 2 commits January 16, 2023 16:33
@dhurley dhurley merged commit c70f185 into main Jan 17, 2023
@dhurley dhurley deleted the github-release-workflow-improvements branch January 17, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aphralG aphralG aphralG approved these changes

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

@craigell craigell Awaiting requested review from craigell

+1 more reviewer

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dhurley dhurley

Labels

chore Pull requests for routine tasks documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhurley @Dean-Coakley @aphralG