Skip to content

Conversation

@Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Jan 20, 2023

Proposed changes

  • Add the following new metrics:
    • nginx.upstream.connect.time
    • nginx.upstream.connect.time.count
    • nginx.upstream.connect.time.max
    • nginx.upstream.connect.time.median
    • nginx.upstream.connect.time.pctl95
    • nginx.upstream.header.time
    • nginx.upstream.header.time.count
    • nginx.upstream.header.time.max
    • nginx.upstream.header.time.median
    • nginx.upstream.header.time.pctl95
  • Improve performance of request time metrics

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@Dean-Coakley Dean-Coakley requested a review from dhurley January 20, 2023 17:54
@netlify
Copy link

netlify bot commented Jan 20, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 9da5c84
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/63d2930735073f0009dfbb3f

@github-actions github-actions bot added the chore Pull requests for routine tasks label Jan 20, 2023
@Dean-Coakley Dean-Coakley self-assigned this Jan 23, 2023
@Dean-Coakley Dean-Coakley marked this pull request as ready for review January 24, 2023 16:32
@Dean-Coakley Dean-Coakley changed the title Add upstream connection time metrics Add upstream connection time and header time metrics Jan 24, 2023
@dhurley
Copy link
Collaborator

dhurley commented Jan 25, 2023

Looks good. You just need to run make deps

@dhurley dhurley self-requested a review January 26, 2023 14:01
@Dean-Coakley Dean-Coakley merged commit e19c723 into main Jan 26, 2023
@Dean-Coakley Dean-Coakley deleted the add-upstream-conn-metrics branch January 26, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants