Skip to content

Add upstream response metrics #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 10, 2023
Merged

Add upstream response metrics #190

merged 9 commits into from
Feb 10, 2023

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Feb 3, 2023 •
edited
Loading

Proposed changes

  • Added upstream response metrics
    • nginx.upstream.response.length
    • nginx.upstream.response.time
    • nginx.upstream.response.time.count
    • nginx.upstream.response.time.max
    • nginx.upstream.response.time.median
    • nginx.upstream.response.time.pctl95
  • Cleaned up nginx_access_log.go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@netlify
Copy link

netlify bot commented Feb 3, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit c26e8cc
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/63e62b3ecf576f0007cfa684

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Feb 3, 2023
Dean-Coakley
Dean-Coakley approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a run of make deps before merging

@aphralG aphralG self-assigned this Feb 8, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 10, 2023
@aphralG aphralG merged commit 7543485 into main Feb 10, 2023
@oliveromahony oliveromahony deleted the add-upstream-response-metrics branch February 10, 2023 15:49
@dhurley dhurley removed documentation Improvements or additions to documentation dependencies labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhurley dhurley dhurley approved these changes

@craigell craigell craigell approved these changes

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

+1 more reviewer

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aphralG aphralG

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aphralG @dhurley @Dean-Coakley @craigell