Skip to content

Fix advanced metrics performance test #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 21, 2022
Merged

Fix advanced metrics performance test #45

merged 6 commits into from
Sep 21, 2022

Conversation

@Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Sep 19, 2022 •
edited
Loading

Proposed changes

  • Resolve compilation errors. Change harness to be more similar to agent implementation.
  • Move packages so valid binaries are created by go build
  • Fix typos

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@github-actions github-actions bot added bug Something isn't working dependencies documentation Improvements or additions to documentation labels Sep 19, 2022
@Dean-Coakley Dean-Coakley self-assigned this Sep 19, 2022
dhurley
dhurley reviewed Sep 20, 2022
View reviewed changes
@Dean-Coakley Dean-Coakley merged commit 81ef694 into main Sep 21, 2022
@Dean-Coakley Dean-Coakley deleted the lint-adv branch September 21, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhurley dhurley dhurley approved these changes

@aphralG aphralG aphralG approved these changes

@oliveromahony oliveromahony Awaiting requested review from oliveromahony

@craigell craigell Awaiting requested review from craigell

Assignees

@Dean-Coakley Dean-Coakley

Labels

bug Something isn't working dependencies documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dean-Coakley @dhurley @aphralG