Skip to content

Conversation

@nickchen
Copy link

@nickchen nickchen commented Sep 30, 2022

Proposed changes

fix the error from out of order Close for Writer. This cause the following error on 1.19:

flate: closed writer

changed the hash in the test, but added new validation against file contents.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@github-actions github-actions bot added bug Something isn't working dependencies labels Sep 30, 2022
@nickchen nickchen self-assigned this Sep 30, 2022
Copy link

@sanathkumarbs sanathkumarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is the change backward compatible if someone is running go 1.18?

I see that the go.mod pins to 1.18:
https://github.com/nginx/agent/blob/main/go.mod#L3

@nickchen
Copy link
Author

nickchen commented Oct 3, 2022

LGTM, is the change backward compatible if someone is running go 1.18?

I see that the go.mod pins to 1.18: https://github.com/nginx/agent/blob/main/go.mod#L3

should be, the agent is still on 1.18, and the pipeline tests passed.

@dhurley dhurley merged commit 56d61a5 into main Oct 3, 2022
@Dean-Coakley Dean-Coakley deleted the fix-golang1.19 branch October 3, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants