Skip to content

fix: Adds Support For NAP 3.12 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2022
Merged

fix: Adds Support For NAP 3.12 #61

merged 1 commit into from
Oct 3, 2022

Conversation

@wicklander-bryant
Copy link
Member

@wicklander-bryant wicklander-bryant commented Oct 3, 2022

Proposed changes

This PR updates the build version to release version mapping to support NGINX App Protect 3.12.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@github-actions github-actions bot added the bug Something isn't working label Oct 3, 2022
@wicklander-bryant wicklander-bryant self-assigned this Oct 3, 2022
sanathkumarbs
sanathkumarbs approved these changes Oct 3, 2022
View reviewed changes
Copy link

@sanathkumarbs sanathkumarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sanathkumarbs sanathkumarbs merged commit e800bdc into main Oct 3, 2022
@wicklander-bryant wicklander-bryant deleted the NMS-37510/nap-3.12-support branch October 3, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@nickchen nickchen nickchen approved these changes

@sanathkumarbs sanathkumarbs sanathkumarbs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wicklander-bryant wicklander-bryant

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wicklander-bryant @nickchen @sanathkumarbs