Proto updates #68
Merged
Proto updates #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliveromahony
requested review from
Dean-Coakley,
aphralG,
craigell,
dhurley and
nickchen
nickchen
approved these changes
Oct 10, 2022
nickchen
left a comment
nickchen
left a comment
There was a problem hiding this comment.
looks good to me, i wonder if we should comment the deprecated field above the field instead of in the same line, that way it'll show as comment addition instead of add/remove.
dhurley
approved these changes
Oct 11, 2022
aphralG
approved these changes
Oct 11, 2022
mohamed-gougam
pushed a commit
that referenced
this pull request
Oct 11, 2022
* Proto updates for future workflows Co-authored-by: o.omahony <o.omahony@f5.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updated the protos for future scenarios
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)