Fix use StrictUnmarshal for app protect yaml unmarshalling #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnmarshalStrict will ensure the payload matches all fields on the struct. See: https://pkg.go.dev/gopkg.in/yaml.v2#UnmarshalStrict for details
Dean-Coakley
requested review from
aphralG,
craigell,
dhurley and
oliveromahony
dhurley
approved these changes
Oct 21, 2022
aphralG
approved these changes
Oct 21, 2022
oliveromahony
approved these changes
Oct 21, 2022
| defer func() { | ||
| err := os.Remove(tc.versionFile) | ||
| assert.Nil(t, err) | ||
| require.NoError(t, err) |
Contributor
There was a problem hiding this comment.
we consistently use assert across the board. Is require a better option? If it is, should we change all assert.Nil on errors to require? I don't mind as long as we are consistent
craigell
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
yaml.StrictUnmarshalin place ofyaml.UnmarshalChecklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)