Skip to content

Move wg to lock #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2022
Merged

Move wg to lock #81

merged 2 commits into from
Oct 20, 2022

Conversation

@oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Oct 20, 2022

Proposed changes

Change wait group to locks

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

djgilcrease
djgilcrease approved these changes Oct 20, 2022
View reviewed changes
Copy link

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliveromahony oliveromahony merged commit c1bd278 into main Oct 20, 2022
@oliveromahony oliveromahony deleted the change_wait_group_to_lock branch October 20, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aphralG aphralG aphralG approved these changes

@dhurley dhurley Awaiting requested review from dhurley

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

@craigell craigell Awaiting requested review from craigell

+1 more reviewer

@djgilcrease djgilcrease djgilcrease approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oliveromahony @djgilcrease @aphralG