fix: Adds Ability To Automatically Create Symlink For NAP #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wicklander-bryant
requested review from
craigell,
nickchen,
oliveromahony and
sanathkumarbs
wicklander-bryant
changed the title
nickchen
reviewed
Nov 1, 2022
sanathkumarbs
approved these changes
Nov 2, 2022
sanathkumarbs
left a comment
sanathkumarbs
left a comment
There was a problem hiding this comment.
LGTM, thanks for accommodating all the changes!
Contributor
|
A |
Contributor
|
also the branch has a reference to internal jira NMS-37057 - can you santize this for external eyes? |
nickchen
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The purpose of this pull request is to allow for Agent to automatically create the necessary symlink that's required for compiled security policy bundles to be used within
nginx.conf. The symlink changes depending on the specific NAP version installed.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)