Fix race conditions #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphralG
requested review from
Dean-Coakley,
craigell,
dhurley and
oliveromahony
dhurley
reviewed
Nov 7, 2022
dhurley
approved these changes
Nov 7, 2022
Collaborator
dhurley
left a comment
dhurley
left a comment
There was a problem hiding this comment.
Much easier now to understand what the mutex are used for. Thanks
oliveromahony
approved these changes
Nov 8, 2022
Dean-Coakley
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix multiple race conditions that were found.
In future race conditions should be tested for before merging. Unit tests will also be added to test for race conditions in the future.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)