Skip to content

Fix: linting and formatting issues #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
+8 −2
Merged

Fix: linting and formatting issues #1392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84f6a04
Fix: linting and formatting issues
aknot242 Nov 1, 2025
a810470
Merge branch 'main' into fix-linting-formatting
JTorreG Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions content/waf/configure/compiler.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ Replace `<path-to-your-nginx-repo.key>` with the location of your client key and
```shell
curl -s https://private-registry.nginx.com/v2/nap/waf-compiler/tags/list --key <path-to-your-nginx-repo.key> --cert <path-to-your-nginx-repo.crt>
```

```json
{
"name": "nap/waf-compiler",
Expand Down Expand Up @@ -245,7 +246,7 @@ There are ways to remediate them based on the context:
| _Policy Bundles have differing global states_ | Recompile all of your bundles from scratch with your custom compiler. Bundles must be compiled with the same compiler: you cannot mix default and custom bundles. |
| _Policy Bundles have differing cookie seeds_ | Recompile all of your bundles from scratch with your custom compiler. Bundles must be compiled with the same compiler: you cannot mix default and custom bundles. |
| _Duplicate policy name found_ | Don't compile multiple policies with the same name, or one policy to multiple bundles. Each policy can be compiled once but a bundle can be re-used. |
| _Duplicate logging profile name found | Don't compile the same logging profile to multiple bundles. Each profile can be compiled once but a bundle can be re-used. |
| _Duplicate logging profile name found_ | Don't compile the same logging profile to multiple bundles. Each profile can be compiled once but a bundle can be re-used. |
| _Timeout waiting for enforcer_ | Likely an internal issue: [contact Support]({{< ref "/waf/support.md" >}}) |
{{< /table >}}

Expand Down Expand Up @@ -288,7 +289,6 @@ When deploying multiple scalability instances (Such as Kubernetes deployment rep

{{< /call-out >}}


## Using the compiler in a CI/CD process

When executing commands inside the compiler container, ensure that you use `/opt/app_protect/bin/apcompile` as the compiler binary.
Expand Down
6 changes: 6 additions & 0 deletions content/waf/configure/converters.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ docker run -it --rm \
-o /tmp/convert/policy.json \
--full-export
```

```json
{
"completed_successfully": true,
Expand Down Expand Up @@ -184,6 +185,7 @@ Replace `waf-compiler-\<version-tag\>:custom` with your compiler image.
```shell
docker run -v `pwd`:`pwd` -w `pwd` --entrypoint /opt/app_protect/bin/convert-signatures waf-compiler-<version-tag>:custom -i /path/to/signatures.xml -o /path/to/signatures.json | jq
```

```json
{
"filename": "/path/to/signatures.json",
Expand All @@ -193,6 +195,7 @@ docker run -v `pwd`:`pwd` -w `pwd` --entrypoint /opt/app_protect/bin/convert-sig
```

**signatures.json**

```json
{
"tag": "user-defined-signatures",
Expand Down Expand Up @@ -346,14 +349,17 @@ This command example generates a signature report with all signature details:
```shell
/opt/app_protect/bin/get-signatures -o /path/to/signature-report.json
```

```json
{
"file_size": 1868596,
"filename": "/path/to/signature-report.json",
"completed_successfully": true
}
```

**signature-report.json**

```json
{
"signatures": [
Expand Down
Loading