From 270f201440fee83493203857d17f34a27ecb8cef Mon Sep 17 00:00:00 2001 From: EutiziStefano <57256061+EutiziStefano@users.noreply.github.com> Date: Mon, 26 Jun 2023 10:36:39 +0200 Subject: [PATCH 1/5] add clusterip values setting Signed-off-by: EutiziStefano <57256061+EutiziStefano@users.noreply.github.com> --- deployments/helm-chart/values.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/deployments/helm-chart/values.yaml b/deployments/helm-chart/values.yaml index d99ff35b98..88a39e0034 100644 --- a/deployments/helm-chart/values.yaml +++ b/deployments/helm-chart/values.yaml @@ -296,6 +296,9 @@ controller: ## The static IP address for the load balancer. Requires controller.service.type set to LoadBalancer. The cloud provider must support this feature. loadBalancerIP: "" + ## The ClusterIP for the Ingress Controller service, autoassigned if not specified. + clusterIP: "" + ## The list of external IPs for the Ingress Controller service. externalIPs: [] From ad93a218aabcad1218ca75955188ca24444cf2ec Mon Sep 17 00:00:00 2001 From: EutiziStefano <57256061+EutiziStefano@users.noreply.github.com> Date: Mon, 26 Jun 2023 10:40:23 +0200 Subject: [PATCH 2/5] Added clusterip to the service template Signed-off-by: EutiziStefano <57256061+EutiziStefano@users.noreply.github.com> --- deployments/helm-chart/templates/controller-service.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/deployments/helm-chart/templates/controller-service.yaml b/deployments/helm-chart/templates/controller-service.yaml index 6daa941133..0e36abb607 100644 --- a/deployments/helm-chart/templates/controller-service.yaml +++ b/deployments/helm-chart/templates/controller-service.yaml @@ -14,6 +14,11 @@ metadata: {{ toYaml .Values.controller.service.annotations | indent 4 }} {{- end }} spec: +{{- if .Values.controller.service.clusterIP }} + {{- if not (eq .Values.controller.service.clusterIP "") }} + clusterIP: {{ .Values.controller.service.clusterIP }} + {{- end }} +{{- end }} {{- if or (eq .Values.controller.service.type "LoadBalancer") (eq .Values.controller.service.type "NodePort") }} {{- if .Values.controller.service.externalTrafficPolicy }} externalTrafficPolicy: {{ .Values.controller.service.externalTrafficPolicy }} From 652713707d2d383ee75e0396e0bebc904231bf86 Mon Sep 17 00:00:00 2001 From: EutiziStefano <57256061+EutiziStefano@users.noreply.github.com> Date: Mon, 26 Jun 2023 10:42:29 +0200 Subject: [PATCH 3/5] added config doc Signed-off-by: EutiziStefano <57256061+EutiziStefano@users.noreply.github.com> --- deployments/helm-chart/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/deployments/helm-chart/README.md b/deployments/helm-chart/README.md index 15a4ade5d1..d684beb9fc 100644 --- a/deployments/helm-chart/README.md +++ b/deployments/helm-chart/README.md @@ -229,6 +229,7 @@ The following tables lists the configurable parameters of the NGINX Ingress Cont |`controller.service.extraLabels` | The extra labels of the service. | {} | |`controller.service.loadBalancerIP` | The static IP address for the load balancer. Requires `controller.service.type` set to `LoadBalancer`. The cloud provider must support this feature. | "" | |`controller.service.externalIPs` | The list of external IPs for the Ingress Controller service. | [] | +|`controller.service.clusterIP` | The clusterIP for the Ingress Controller service, autoassigned if not specified. | "" |`controller.service.loadBalancerSourceRanges` | The IP ranges (CIDR) that are allowed to access the load balancer. Requires `controller.service.type` set to `LoadBalancer`. The cloud provider must support this feature. | [] | |`controller.service.name` | The name of the service. | Autogenerated | |`controller.service.customPorts` | A list of custom ports to expose through the Ingress Controller service. Follows the conventional Kubernetes yaml syntax for service ports. | [] | From 45524ee8d135350b229b278a9d1e495c0d6ce958 Mon Sep 17 00:00:00 2001 From: Luca Comellini Date: Tue, 15 Aug 2023 09:47:48 -0700 Subject: [PATCH 4/5] Update deployments/helm-chart/templates/controller-service.yaml Signed-off-by: Luca Comellini --- deployments/helm-chart/templates/controller-service.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/deployments/helm-chart/templates/controller-service.yaml b/deployments/helm-chart/templates/controller-service.yaml index 0e36abb607..a25de94561 100644 --- a/deployments/helm-chart/templates/controller-service.yaml +++ b/deployments/helm-chart/templates/controller-service.yaml @@ -15,9 +15,7 @@ metadata: {{- end }} spec: {{- if .Values.controller.service.clusterIP }} - {{- if not (eq .Values.controller.service.clusterIP "") }} clusterIP: {{ .Values.controller.service.clusterIP }} - {{- end }} {{- end }} {{- if or (eq .Values.controller.service.type "LoadBalancer") (eq .Values.controller.service.type "NodePort") }} {{- if .Values.controller.service.externalTrafficPolicy }} From 731d0050c730e18073c10b600684c6068f78988d Mon Sep 17 00:00:00 2001 From: Luca Comellini Date: Tue, 15 Aug 2023 11:20:27 -0700 Subject: [PATCH 5/5] Update deployments/helm-chart/README.md Signed-off-by: Luca Comellini --- deployments/helm-chart/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deployments/helm-chart/README.md b/deployments/helm-chart/README.md index d684beb9fc..20b8968a3a 100644 --- a/deployments/helm-chart/README.md +++ b/deployments/helm-chart/README.md @@ -229,7 +229,7 @@ The following tables lists the configurable parameters of the NGINX Ingress Cont |`controller.service.extraLabels` | The extra labels of the service. | {} | |`controller.service.loadBalancerIP` | The static IP address for the load balancer. Requires `controller.service.type` set to `LoadBalancer`. The cloud provider must support this feature. | "" | |`controller.service.externalIPs` | The list of external IPs for the Ingress Controller service. | [] | -|`controller.service.clusterIP` | The clusterIP for the Ingress Controller service, autoassigned if not specified. | "" +|`controller.service.clusterIP` | The clusterIP for the Ingress Controller service, autoassigned if not specified. | "" | |`controller.service.loadBalancerSourceRanges` | The IP ranges (CIDR) that are allowed to access the load balancer. Requires `controller.service.type` set to `LoadBalancer`. The cloud provider must support this feature. | [] | |`controller.service.name` | The name of the service. | Autogenerated | |`controller.service.customPorts` | A list of custom ports to expose through the Ingress Controller service. Follows the conventional Kubernetes yaml syntax for service ports. | [] |