Skip to content

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 13, 2023

Proposed changes

Refactor test setup matrix

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@codecov
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be56efb) 52.09% compared to head (0eca4ed) 52.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4795      +/-   ##
==========================================
- Coverage   52.09%   52.08%   -0.02%     
==========================================
  Files          60       60              
  Lines       17376    17376              
==========================================
- Hits         9052     9050       -2     
- Misses       8008     8010       +2     
  Partials      316      316              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oseoin oseoin marked this pull request as ready for review December 22, 2023 15:41
@oseoin oseoin requested a review from a team as a code owner December 22, 2023 15:41
@oseoin oseoin merged commit ac196d0 into main Jan 2, 2024
@oseoin oseoin deleted the test-matrix-json branch January 2, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants