From 1e80cea27f8e492f8df10a1d18d5c29f21043c32 Mon Sep 17 00:00:00 2001 From: Paul Abel Date: Tue, 27 Feb 2024 12:17:24 +0000 Subject: [PATCH 1/2] Ignore lint errors about package comments --- .golangci.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index 8e38536056..86ad2ab504 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -17,7 +17,6 @@ linters-settings: - name: if-return - name: increment-decrement - name: indent-error-flow - - name: package-comments - name: range - name: receiver-naming - name: redefines-builtin-id From dd5126f9c169c8fa3ca1c856dc8ef706449a6511 Mon Sep 17 00:00:00 2001 From: Paul Abel Date: Wed, 28 Feb 2024 11:04:15 +0000 Subject: [PATCH 2/2] rebuild base image fix --- .github/workflows/ci.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4a04cd7228..3ce7bab962 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -269,8 +269,11 @@ jobs: - name: Check if base images exist id: base_exists run: | - docker manifest inspect gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-base/oss:${{ needs.checks.outputs.docker_md5 }}-debian - echo "exists=$?" >> $GITHUB_OUTPUT + if docker manifest inspect gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-base/oss:${{ needs.checks.outputs.docker_md5 }}-debian; then + echo "exists=0" >> $GITHUB_OUTPUT + else + echo "exists=1" >> $GITHUB_OUTPUT + fi if: ${{ needs.checks.outputs.forked_workflow == 'false' }} - name: Rebuild base images