From 4e84313fceac0394b668cc5d78db82e2aad7d2e3 Mon Sep 17 00:00:00 2001 From: Venktesh Date: Wed, 25 Sep 2024 10:52:13 +0100 Subject: [PATCH 1/2] add retry to version check in logs --- tests/suite/test_build_info.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/suite/test_build_info.py b/tests/suite/test_build_info.py index c36f00dfc0..4e7d464b2c 100644 --- a/tests/suite/test_build_info.py +++ b/tests/suite/test_build_info.py @@ -18,10 +18,14 @@ def test_build_version(self, ingress_controller, kube_apis, ingress_controller_p chart = yaml.safe_load(f) ic_ver = chart["appVersion"] print(f"NIC version from chart: {ic_ver}") - _info = self.send_build_info(kube_apis, ingress_controller_prerequisites) - _version = _info[_info.find("Version=") + len("Version=") : _info.rfind("GitCommit=")] + count = 0 + while "Version=" not in _info and count < 5: + _info = self.send_build_info(kube_apis, ingress_controller_prerequisites) + count += 1 + _version = _info[_info.find("Version=") + len("Version=") : _info.rfind("Commit=")] logging.info(_version) + print(f"Version from pod logs: {_version}") assert _version != " " assert ic_ver in _version From e607329c9d2e06deb31feed39dbe425eefbdd5ec Mon Sep 17 00:00:00 2001 From: Venktesh Date: Wed, 25 Sep 2024 11:17:58 +0100 Subject: [PATCH 2/2] add sleep --- tests/suite/test_build_info.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/suite/test_build_info.py b/tests/suite/test_build_info.py index 4e7d464b2c..42c5611849 100644 --- a/tests/suite/test_build_info.py +++ b/tests/suite/test_build_info.py @@ -1,5 +1,6 @@ import io import logging +import time import pytest import yaml @@ -23,6 +24,7 @@ def test_build_version(self, ingress_controller, kube_apis, ingress_controller_p while "Version=" not in _info and count < 5: _info = self.send_build_info(kube_apis, ingress_controller_prerequisites) count += 1 + time.sleep(1) _version = _info[_info.find("Version=") + len("Version=") : _info.rfind("Commit=")] logging.info(_version) print(f"Version from pod logs: {_version}")