-
Notifications
You must be signed in to change notification settings - Fork 142
Alignment for Conditions messages format #4253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tataruty
commented
Nov 11, 2025
tataruty
commented
Nov 11, 2025
tataruty
commented
Nov 11, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4253 +/- ##
==========================================
- Coverage 86.15% 86.09% -0.06%
==========================================
Files 131 131
Lines 14196 14205 +9
Branches 35 35
==========================================
Hits 12230 12230
- Misses 1764 1769 +5
- Partials 202 206 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjberman
reviewed
Nov 11, 2025
ef756e8 to
ec32a94
Compare
sjberman
approved these changes
Nov 11, 2025
ciarams87
approved these changes
Nov 11, 2025
ec32a94 to
938b93e
Compare
sjberman
reviewed
Nov 11, 2025
sjberman
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
We have some inconsistent messages in status conditions of resources.
(below, we use ConditionType/Status/Reason notation)
A few examples:
"The route is accepted" for HTTPRoute Accepted/True/Accepted . However, we have "GatewayClass is accepted" for GatewayClass Accepted/True/Accepted.
"unsupported value" for Listener Accepted/False/UnsupportedValue. Note that in most other messages, first letter is capitalized.
"invalid backendTLSPolicy" for BackendTLSPolicy Accepted/False/Invalid. Note: first letter is not capitalized, backendTLSPolicy is spelled differently from other similar places. Needed "BackendTLSPolicy"
Acceptance criteria:
Come up with consistent style
Capture rules if necessary
Bring messages with accordance to the style
Solution:
Decided to use next format:
Theif can beinference pool=>InferencePool.Testing: Unit tests.
Please focus on (optional):
There is one case when Condition message is built as an error and since error cannot be capitalized, added linter exception for that line
Closes #1809
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.