Skip to content

Conversation

@sjberman
Copy link
Collaborator

Cherrypick of #4186

Problem: Need to allow disabling cert-generator with a Helm value.

Solution: Allow disabling cert-generator with a Helm value.

Testing: Allow disabling cert-generator with a Helm value.

Allow disabling cert-generator with a Helm value

Problem: Need to allow disabling cert-generator with a Helm value.

Solution: Allow disabling cert-generator with a Helm value.

Testing: Allow disabling cert-generator with a Helm value.
@sjberman sjberman requested a review from a team as a code owner November 13, 2025 13:55
@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.19%. Comparing base (de35707) to head (7fb116c).
⚠️ Report is 1 commits behind head on release-2.2.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.2    #4280      +/-   ##
===============================================
+ Coverage        86.16%   86.19%   +0.02%     
===============================================
  Files              131      131              
  Lines            14316    14316              
  Branches            74       74              
===============================================
+ Hits             12336    12340       +4     
+ Misses            1777     1774       -3     
+ Partials           203      202       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman enabled auto-merge (squash) November 13, 2025 14:17
@sjberman sjberman merged commit c0a6ed2 into release-2.2 Nov 13, 2025
68 of 69 checks passed
@sjberman sjberman deleted the helm/cert-generator branch November 13, 2025 17:00
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation helm-chart Relates to helm chart release-notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants