diff --git a/tests/README.md b/tests/README.md index d58138dd1e..f543cb9716 100644 --- a/tests/README.md +++ b/tests/README.md @@ -102,8 +102,8 @@ make update-firewall-with-local-ip ### Step 2 - Build and Load Images -Loading the images only applies to a `kind` cluster. If using a cloud provider, you will need to tag and push -your images to a registry that is accessible from that cloud provider. +Loading the images only applies to a `kind` cluster. If using GKE, you will need to tag and push +your images to a registry that is accessible from GKE. ```makefile make build-images load-images TAG=$(whoami) @@ -115,6 +115,8 @@ Or, to build NGF with NGINX Plus enabled (NGINX Plus cert and key must exist in make build-images-with-plus load-images-with-plus TAG=$(whoami) ``` +When building images to run on GKE, you'll need to specify `GOARCH=amd64` in the build command if your local system doesn't default to that architecture. + For the telemetry test, which requires a OTel collector, build an image with the following variables set: ```makefile @@ -314,6 +316,8 @@ incremental changes and copy your local changes to the VM to test, you can run make sync-files-to-vm ``` +> Note: if just running longevity tests, skip to the [Longevity section](#longevity-testing). + To set up the GCP environment with the router and VM and then run the tests, run the following command: ```makefile diff --git a/tests/framework/resourcemanager.go b/tests/framework/resourcemanager.go index 2382d17102..ee7e84355b 100644 --- a/tests/framework/resourcemanager.go +++ b/tests/framework/resourcemanager.go @@ -488,7 +488,7 @@ func (rm *ResourceManager) WaitForPodsToBeReady( var podsReady int for _, pod := range podList.Items { for _, cond := range pod.Status.Conditions { - if cond.Type == core.PodReady && cond.Status == core.ConditionTrue { + if cond.Type == core.PodReady && (cond.Status == core.ConditionTrue || cond.Reason == "PodCompleted") { podsReady++ } } diff --git a/tests/suite/system_suite_test.go b/tests/suite/system_suite_test.go index 31ce49c0d0..edda7654ab 100644 --- a/tests/suite/system_suite_test.go +++ b/tests/suite/system_suite_test.go @@ -257,6 +257,7 @@ func createNGFInstallConfig(cfg setupConfig, extraInstallArgs ...string) framewo extraInstallArgs = append( extraInstallArgs, "--set", "nginxGateway.config.logging.level=debug", + "--set", "nginx.config.logging.agentLevel=debug", ) }