-
Notifications
You must be signed in to change notification settings - Fork 148
Add all load balancing methods #4325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
912649a to
80fe344
Compare
Collaborator
|
In your |
Collaborator
|
And your |
sjberman
reviewed
Nov 21, 2025
internal/controller/nginx/config/policies/clientsettings/validator.go
Outdated
Show resolved
Hide resolved
4255861 to
f3bddb7
Compare
sjberman
reviewed
Nov 21, 2025
internal/controller/nginx/config/policies/upstreamsettings/validator.go
Outdated
Show resolved
Hide resolved
sjberman
reviewed
Nov 21, 2025
72e70cd to
49b16b1
Compare
sjberman
approved these changes
Nov 21, 2025
bjee19
requested changes
Nov 22, 2025
internal/controller/nginx/config/policies/upstreamsettings/validator.go
Outdated
Show resolved
Hide resolved
bjee19
reviewed
Nov 24, 2025
internal/controller/nginx/config/policies/upstreamsettings/validator_test.go
Show resolved
Hide resolved
9863bd1 to
758a284
Compare
Co-authored-by: Saylor Berman <s.berman@f5.com>
fdb0722 to
8783043
Compare
bjee19
approved these changes
Nov 24, 2025
Contributor
bjee19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users want to specify all load balancing methods.
Solution: Specify a way for user to be able to specify all combinations of load balancing methods.
Testing:
Manual testing
Errors
hash key format wrong
plus features with OSS
Spec does not allow any other features so do not need to validate for plus(everything allowed)
USP is set for tea svc for all , verified traffic passing for all
Only mentioning special cases -- round_robin, hash and hash consistent
OSS
Plus verified on tea svc
Verified all load balancing methods with working traffic for plus
Closes #4190
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.