Degrades the performance to get the values of all the keys using key() function

[coolkingh]

Using keys() function we can get all the keys and then to fetch the value of all the keys we have to call get() function in a loop and it will lead to read locks which degrades the performance in case there is huge number of keys.

Use case : Multiple users are connected to the persistent connection ( proxying to RDP ) and we want to update the activity of the user in the shared dict and periodic daemon will fetch the activity from the shared dict and update that details in the database.

If we could have got the value along with key then it would be great.

[xeioex]

hi @coolkingh,

What about the method items() that returns the key-value pairs?

[coolkingh]

@xeioex I will look into it. Thanks

[coolkingh]

There is no items() function currently. I got the below error. I also checked the code but didn't find anything related to items()

2023/09/06 08:51:35 [error] 17547#17547: js exception: TypeError: (intermediate value)["items"] is not a function

Below is the code snippet :-

ngx.shared.foo.set("ro", 1);
ngx.shared.foo.set("ko", 2);
ngx.log(ngx.INFO,ngx.shared.foo.items());

[xeioex]

Hi @coolkingh,

Yes, there is no items() right now. The question is, will items() which returns key-value pairs help with your task?

[coolkingh]

Yes, if it returns all the key value pairs which are not expired

[xeioex]

Hi @coolkingh,

Feel free to test the following patch: https://gist.github.com/xeioex/663613ccbc374fdb61893292b7a97c72. I plan to commit it after a review.

The patch adds items() method which returns all non-expired key-value pairs.

[xeioex]

Implemented in fa2c985.