Apply -enable-snippets cli arg to Ingresses (#2124) #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Merged
soneillf5
approved these changes
Oct 28, 2021
ciarams87
force-pushed
the
cherry-pick-ingress-fix
branch
from
6d58a4a
to
d2f871d
Compare
pleshakov
approved these changes
Oct 28, 2021
ciarams87
commented
Oct 28, 2021
| @@ -0,0 +1,20 @@ | |||
| apiVersion: networking.k8s.io/v1 | |||
There was a problem hiding this comment.
needs to be updated to v1beta1
There was a problem hiding this comment.
changed to extensions/v1beta1 as all the other Ingresses are of that version. updated the python code to use extensions/v1beta1 as well.
* Apply -enable-snippets cli arg to Ingresses * Update docs * add snippet flag python tests * removing snippets check as we rely on validation * removing used param Co-authored-by: Sean O'Neill <s.oneill@f5.com>
pleshakov
force-pushed
the
cherry-pick-ingress-fix
branch
from
d2f871d
to
2c2f09b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply -enable-snippets cli arg to Ingresses
Update docs
add snippet flag python tests
removing snippets check as we rely on validation
removing used param
Co-authored-by: Sean O'Neill s.oneill@f5.com
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.