fix: Include parsed comments between arguments only when ParseComment s is true #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornj
reviewed
Jun 26, 2023
rshyamsu
force-pushed
the
add-comment-directives
branch
2 times, most recently
from
cb871fe to
91a3c26
Compare
ornj
approved these changes
Jun 26, 2023
oliveromahony
approved these changes
Jun 27, 2023
valyria257
approved these changes
Jun 27, 2023
…s is true Comments between arguments should be added to the parsed result only if the ParseComments ParseOption is true. This check was previously missing and has been added as part of this fix. A unit test has also been added to validate this.
rshyamsu
force-pushed
the
add-comment-directives
branch
from
91a3c26 to
6e8c61d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments between arguments should be added to the parsed result only if the ParseComments ParseOption is true. This check was previously missing and has been added as part of this fix.
A unit test has also been added to validate this.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)