-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lock1 fails if provided string contains folders #68
Comments
A simple workaround could be to replace any |
Bugfix release. Trigger for release was the updated conduit-algorithms as it makes a huge difference: Version 0.8.1 2018-06-05 by luispedro * Update to LTS-11.12 (for faster conduit-algorithms used in collect()) * Add fallback for character encoding on systems with bad locale support * Fixed lock1 when used with paths (#68) * Fixed expansion of searchdir with external modules (#56)
Bugfix release. Trigger for release was the updated conduit-algorithms as it makes a huge difference: Version 0.8.1 2018-06-05 by luispedro * Update to LTS-11.12 (for faster conduit-algorithms used in collect()) * Add fallback for character encoding on systems with bad locale support * Fixed lock1 when used with paths (#68) * Fixed expansion of searchdir with external modules (#56)
@luispedro Realized one use-case of this code that got broken with the above fix. file_with_full_paths.txt
|
Yeah, that's how it should work. |
Fix in in place. Only missing a test-case to avoid future regressions. |
Thanks! This should be mentioned in the Test could be:
|
That last was already https://github.com/ngless-toolkit/ngless/blob/master/tests/parallel_folder_lock/lock.ngl minus the |
The idea of adding |
Yup: 2eff033 - What I was missing is that the tests run with |
Many small fixes rather than any large new features. Full ChangeLog: * Fix to lock1's return value when used with paths (#68 - reopen) * Support _F/_R suffixes for forward/reverse in load_mocat_sample * samtools_sort() now accepts by={name} to sort by read name * Fixed bug where header was printed even when STDOUT was used * Fixed bug where writing interleaved FastQ to STDOUT did not work as expected * Indices created by bwa and minimap2 are now versioned * arg1 in external modules is no longer always treated as a path * Added expand_searchpath to external modules API (closes #56) * Fixed bug where detection of Fastq encoding was not performed on the second pair * Fix saving fastq sets with --subsample (issue #85) * Add __extra_megahit_args to assemble() (issue #86) * Better error message when user mis-specifies the ngless version string (issue #84) * Support NO_COLOR environment variable (issue #83) * Garbage collection for temporary files (issue #79) * Rename --search-dir to --search-path for consistency with other API * Fix corner case with select() producing incorrect CIGAR strings (#92) * Always check output file writability (#91) * Make paired() accept encoding argument
errors with:
The text was updated successfully, but these errors were encountered: