New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tar expansion should not use so much memory #77

Closed
luispedro opened this Issue Jul 11, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@luispedro
Copy link
Collaborator

luispedro commented Jul 11, 2018

Currently, tar expansion is done in such a way that files are expanded in memory as they are extracted. The relevant function is:

expandTar :: Tar.Entries Tar.FormatError -> NGLessIO ()

The tar-conduit package should be able to stream the file correctly.

unode added a commit to unode/ngless that referenced this issue Oct 29, 2018

@luispedro

This comment has been minimized.

Copy link
Collaborator Author

luispedro commented Jan 13, 2019

Once snoyberg/tar-conduit#26 and snoyberg/tar-conduit#27 are closed (and make it into a stackage LTS), we can implement tar expansion with tar-conduit and close this for good.

@luispedro luispedro closed this in 3a157d3 Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment