Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 🥳 getRandomInRange can return same value as min value #326

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

okinawaa
Copy link
Contributor

I have verified that the value returned by getRandomInRange may be equal to the min value

image

I tried to modify getRandomInRange to return a value greater than the min value always, but I did not modify the function because the developer might think that the return value also contains a min value(can be equal).

Which do you prefer, fixing the test code or modifying the function?

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

test code always pass all test

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I have verified that the value returned by getRandomInRange may be equal
to the min value
@stackblitz
Copy link

stackblitz bot commented Nov 18, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal
Copy link
Member

Getting min is valid

@NetanelBasal NetanelBasal merged commit 88472a2 into ngneat:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants