Permalink
Switch branches/tags
Nothing to show
Commits on Nov 6, 2011
  1. cleaned up uberj's code. created an explicit main function. added fea…

    Kevin Ngo committed Nov 6, 2011
    …ture to scrape soundcloud links from any page and download all at once
  2. Removed retry attemps from open_url. It made more sense to have one c…

    uberj committed Nov 6, 2011
    …entralized place where retry logic was being applied.
  3. Reworked how I implimented the error checking that was removed. There…

    uberj committed Nov 6, 2011
    … are two places where retry-logic needs to be. 1) First when you get the html (which might not be html), and 2) where you try to get the stream token.
    
    This is still kind of a hack, but it works. I'm not sure if this is the best way to do it.
  4. Re-introduced a whole bunch of error handling code. This is important…

    uberj committed Nov 6, 2011
    …, go ahead and change stuff, but please make sure errors are *still* handled after things get shifted around.
  5. Carpet bombing exception handling is bad. You don't know if you have …

    uberj committed Nov 6, 2011
    …run into a different error.
    
    It's not a good idea to exit while in a function. Return error values and exit out of main, or some other "main"ish place. Functions should mutate data. They should not kill the program 2 stacks deep.
    
    Also, where did the retry logic go?
  6. cleaned up the code, fixed typos, made sane default, and use random f…

    Kevin Ngo committed Nov 6, 2011
    …ile names only if it can't fetch title
  7. Added random name generator. This will be usefull if you want random …

    uberj committed Nov 6, 2011
    …names... or if fetching the name fails.
  8. Changes:

    uberj committed Nov 6, 2011
    * added *.mp3 to ignore file.
    * added the -u option that changes all spaces to underscores
    * added retry logic
        + the retry logic should probably end up in a function somewhere
    * Handled 404 errors in open_url
    * Introduced a MAX_NUMBER_OF_TRIES constant. (Should this be a passed in option?)
  9. renamed to soundcloud-dl, fixed shebang

    Kevin Ngo committed Nov 6, 2011
  10. merge

    Kevin Ngo committed Nov 6, 2011
  11. Adding logic to deal with different options

    David committed Nov 6, 2011
  12. Adding a readme

    David committed Nov 6, 2011
  13. Refactoring for reability

    David committed Nov 6, 2011
  14. Getting song title too

    David committed Nov 6, 2011
Commits on Nov 5, 2011
  1. Merge pull request #1 from uberj/patch-1

    Kevin Ngo committed Nov 5, 2011
    uberj's typo fix
  2. Add me as a contributer?

    uberj committed Nov 5, 2011
  3. finish. now successfully downloads .mp3 files and saves it to file. n…

    Kevin Ngo committed Nov 5, 2011
    …eed to regex out title of song. (with much help from thedjpetersen and uberj
  4. initial commit, can't get cookies out

    Kevin Ngo committed Nov 5, 2011