Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close listeners in a few more error paths #20

Merged
merged 1 commit into from May 11, 2019

Conversation

Projects
None yet
3 participants
@euank
Copy link
Collaborator

commented May 10, 2019

I've seen evidence that a listener is probably being leaked somewhere, and these are all the spots I found a missing close...

I'm not confident that the problem is actually here vs the application using the library, but these changes do seem right.

@inconshreveable
Copy link

left a comment

lgtm

@joshuarubin
Copy link

left a comment

LGTM

@euank euank merged commit 470cbba into ngrok:master May 11, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@euank euank deleted the euank:more-close branch May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.